Closed brynpickering closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
6db0657
) 95.76% compared to head (9625db9
) 95.77%. Report is 1 commits behind head on main.
Closing as, after some testing, locale
setting turns out to not be that powerful. E.g., swiss locale can't handle 1'000.0
and german locale can't handle 1.000,0
. Users will just need to sanitise their Excel data before loading it into Calliope.
Fixes issue where data sources contain numeric data with separators.
E.g.,
25,000
would be loaded by stored in CSV as "25,000" and pandas can't natively coerce that to a numeric dtype.Summary of changes in this pull request:
,
being the thousand separator and.
the decimal point. It would probably be feasible for a user to change the locale manually (locale.setlocale(..)
) if they had data using other separators.Reviewer checklist: