Closed brynpickering closed 6 days ago
This is something @sjpfenninger and I went back and forth on a lot. Would you prefer dimensions
and add_dimensions
everywhere, or dims
and add_dims
@irm-codebase @FLomb ?
This is something @sjpfenninger and I went back and forth on a lot. Would you prefer
dimensions
andadd_dimensions
everywhere, ordims
andadd_dims
@irm-codebase @FLomb ?
I don't have a strong preference for either of the two, but I agree it'd be nice to have consistency across all functions for which the "dimension" concept is part of the name.
@brynpickering : I agree with Francesco.
dims
is shorter, and probably more enjoyable for users. I think it's fine to keep it and change add_dims
, but we need to make sure that all the user-side code / YAML stuff sticks to that convention. Basically:
User-side:
dims
.dims
or dimensions is fine (we do this for techs
/ technology, with little complaints).
Internally (code variables and docstrings): All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.07%. Comparing base (
872978d
) to head (41966a8
). Report is 15 commits behind head on main.:exclamation: Current head 41966a8 differs from pull request most recent head 2b649cc
Please upload reports for the commit 2b649cc to get more accurate results.
Fixes #612
Reviewer checklist