Rework calliope model attributes

calliope-project / calliope

A multi-scale energy systems modelling framework

https://www.callio.pe

Apache License 2.0

276 stars 89 forks source link

Rework calliope model attributes #625

Closed irm-codebase closed 2 days ago

irm-codebase commented 6 days ago

Fixes #619

Summary of changes in this pull request

Introduces better handling of Calliope configuration (by differentiating between configuration from files, overrides and runtime).
Limits backend access to only things it needs (math, defaults, build config, data)
Better data handling to avoid duplicating information between the backend and the model object (unless necessary).
Removes unnecessary attributes

See this table: https://github.com/calliope-project/calliope/issues/619#issuecomment-2197236102

Reviewer checklist

[ ] Test(s) added to cover contribution
[ ] Documentation updated
[ ] Changelog updated
[ ] Coverage maintained or improved

irm-codebase commented 6 days ago

@brynpickering first step towards the new attribute setup. This one fixes how math dictionaries are handled. Some tests related to operate mode seem to be failing... but I thought that feature was not working???

I'll try to debug that before continuing.

brynpickering commented 4 days ago

operate mode is working (#539)!

irm-codebase commented 4 days ago

@brynpickering this fix is causing some VERY weird behavior on the backend (actually reintroducing #623) and around operate mode. I will try to re-approach with your suggestions and by first only cleaning model.py. I will only introduce the backend changes after making sure that everything on the front is behaving adequately.

irm-codebase commented 4 days ago

operate mode is working (#539)!

In that case, shouldn't we re-activate the tests that check it / remove the unnecessary ones?

irm-codebase commented 2 days ago

My approach was incorrect. Retrying!