search

calliope-project / euro-calliope

A workflow to build models of the European electricity system for Calliope.
https://euro-calliope.readthedocs.io
MIT License
31 stars 18 forks source link

Feature: heat pump cop profiles #393

Closed brynpickering closed 5 months ago

brynpickering commented 5 months ago

Fixes #80 by adding COP profiles.

Builds onchanges made to input weather data in #390.

Checklist

Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.

timtroendle commented 5 months ago

I am confused. Why are you intending to merge into the feature-hot-water branch? Which PR to check first? I will now have a look at the feature-hot-water PR.

brynpickering commented 5 months ago

I am confused. Why are you intending to merge into the feature-hot-water branch? Which PR to check first? I will now have a look at the feature-hot-water PR.

To reduce the diff that you would be reviewing. Sorry for pushing this before the hot water one was ready! I thought it would be nice to have it online so that you could review it while I was fixing up review comments on the hot water PR.

brynpickering commented 5 months ago

would it possibly to extend this PR to actually building in the heat pump? It seems to me that only a few minor things are missing so that we'd actually have heat pumps, right?

Do you mean extending to having the electricity demand from heating be based on the when2heat profile & heat pump COP? Or do you mean having heat pumps as a templated technology option?

timtroendle commented 5 months ago

Either of the two, but it seems the latter makes more sense. It wouldn't be a big effort, would it?

It's just so that this PR is not just some unconnected data processing step that'll make sense only after other PRs are merged but a feature that can be integrated and used right away.

brynpickering commented 5 months ago

@timtroendle I have:

  1. added a heat pump supply template.
  2. processed the heat pump outputs into a COP timeseries file.
  3. moved data checks to tests.

It was a bit more work than expected ;)

I also found it a pain to debug tests as you can't drop into the debugger with breakpoint() in the same way as with the other scripts. It requires adding --pdb to the pytest call. I've added functionality to allow that in the test rule/runner.

brynpickering commented 5 months ago

Failing tests are due to too many requests to access either the miniconda .sh file or a cached version of it. Not sure how we resolve that.

timtroendle commented 5 months ago

I wouldn't worry too much about the failing tests. @setup-miniconda's tests are failing, too, so I am assuming they will have this high up on their agenda.

timtroendle commented 5 months ago

👆Oops, I wanted to suggest edits and now I've committed them. Must have missed the "suggest" option, sorry.

brynpickering commented 5 months ago

@timtroendle I think that's all done now. I've opened various issues for things that need to be resolved off the back of this PR.

~EDIT: nvm, still need to update docs with new file and fix a docs issue.~