search

callmearta / clubhouse-desktop

An unofficial Clubhouse desktop client
Other
212 stars 38 forks source link

Fix button new pr #28

Closed miladini closed 3 years ago

miladini commented 3 years ago

This is the same as #26 after rebasing against the main branch.

It's been very long time since I coded in javascript, in case my array manipulation is not optimal, please leave a comment in the review. Also, I tested this logic against this commit: 876c687b0819c18b2852e0edbcb14025348858f2 and not the current tip of main: 703d6d1db7d2dd2c62862f1da2a942c82ad874ee. And when tested, everything worked as expected.

Could one of you please test this if you get a chance?

@callmearta @eamirgh

miladini commented 3 years ago

Oh, I didn't realize this commit 9b3484dae47cc457bac9e02ac66c0be1f911a26c was new! It seems like you @callmearta have attempted to fix the follow button. I haven't tested this version, but if you already tested it, then we can close this PR.

Does this work though? I was wondering where following_ids is set for the first time?

miladini commented 3 years ago

I just tested this and it works as expected.

callmearta commented 3 years ago

What's the main purpose of this PR mate? If it's fixing the follow button i've already fixed it in latest version.

miladini commented 3 years ago

I see. I missed that last commit. Let's close this PR then.