search

callmearta / clubhouse-desktop

An unofficial Clubhouse desktop client
Other
212 stars 38 forks source link

use high quality audio #46

Closed jishnu7 closed 3 years ago

jishnu7 commented 3 years ago

high_quality without stereo can also be used. But I couldn't clearly notice any difference.

I tried setting up it as a run-time option, but I guess either you'll have to restart the application or exit a group and re-join. So for now, setting this as default.

Fixes https://github.com/callmearta/clubhouse-desktop/issues/16

callmearta commented 3 years ago

The problem with sound quality won't be fixed by using these options. It has something to do with AgoraSDK web version which causes the laggy sound. Also using the native AgoraSDK won't be possible since it doesn't run on linux platforms. For now i'll accept this PR to see if anyone notices any difference. Thank you

jishnu7 commented 3 years ago

@callmearta There is noticeable difference with this option, but still not perfect though. Also, I have noticed that there are more options in the newer electron SDK. I wonder why they have this option if it doesn't make any difference.

Also, have you tried using any other codec, than h264?

callmearta commented 3 years ago

@jishnu7 There's not much other options rather than h264. There's only vp6 which i've tried and didn't make anything better.