callmearta / clubhouse-desktop

An unofficial Clubhouse desktop client

Other

214 stars 38 forks source link

Point version of clubhouse-api to new commit and fix notifications error #50

Closed vivekkj123 closed 3 years ago

vivekkj123 commented 3 years ago

Hi, This pull request is for solving #47 which is related to notifications. I found that it is due to that the package-lock.json is pointing to an older commit of clubhouse-api repository. After that commit, I found that you've changed API endpoint of getNotifications from /follow to /get_notifications. So I've changed the commit ID of clubhouse-api module in package-lock.json to the latest commit. Hope this will fix all errors related to notifications. Thanks, Vivek K J

vivekkj123 commented 3 years ago

49 also seems to be related to this. So this PR would be able to close that too..

callmearta commented 3 years ago

Are you sure package.json doesn't need to change?

vivekkj123 commented 3 years ago

Yes. package.json doesn't need any change since there is no reference to the version or commit of clubhouse-api module.

callmearta commented 3 years ago

@vivekkj123 Did you check it youself to see if those 2 problems would resolve?

vivekkj123 commented 3 years ago

@callmearta I've tried to reproduce these 2 problems in my fork and I couldn't.

callmearta commented 3 years ago

Ok then. Thanks. Merged.

jishnu7 commented 3 years ago

@callmearta @vivekkj123 having the commit ID, in the package.json is the best way to solve this.

dependency: {
 ...
  "clubhouse-api": "git+https://github.com/callmearta/clubhouse-api.git#acac75f"
 ...
}

this will make sure the exact commit is installed and provides consistency across all environments.