search

callmearta / clubhouse-desktop

An unofficial Clubhouse desktop client
Other
214 stars 38 forks source link

Fix mute button #54

Open jishnu7 opened 3 years ago

jishnu7 commented 3 years ago

Clubhouse api doesn't send unmute field for the active user. So we should keep our own flag to store the status.

Fixes https://github.com/callmearta/clubhouse-desktop/issues/48

stultus commented 3 years ago

I can confirm that the state of the mute button is consistent now. But the mute status shown on the icon of the user is inconsistent. It goes back to mute state if we refresh the room. see the below screenshot. you can see that even when the user is in unmute, it is shown as mute on the profile icon. image

jishnu7 commented 3 years ago

@stultus That should be fixed now. Let me know if it works.

callmearta commented 3 years ago

I should check this one. I'll test it when i have the time and if it worked i'll merge it. Thank you for your PR

stultus commented 3 years ago

@callmearta were you able to test this?

borhanak commented 3 years ago

The code is not verified