Don't hide titlebar and fix icon

callmearta / clubhouse-desktop

An unofficial Clubhouse desktop client

Other

214 stars 38 forks source link

Don't hide titlebar and fix icon #59

Closed vivekkj123 closed 3 years ago

vivekkj123 commented 3 years ago

Hi, This PR aims to provide the title bar on top for resizing, and minimizing the window. This PR also fixes the bug of custom icon doesn't show on the dock. I've tested both on Linux and Windows.

callmearta commented 3 years ago

Why did you remove the OS check? on Mac the titlebar sucks and isn't pretty at all. It'd be nice if you add OS check and provide the menubar and titlebar only if user isn't a mac user.

vivekkj123 commented 3 years ago

Added. Check now.

vivekkj123 commented 3 years ago

@callmearta ☝

callmearta commented 3 years ago

Merging. Thank you