search

callmekass / pfSense-palenight

[DEPRECATED] A palenight inspired theme for pfSense and pfSense+
Apache License 2.0
35 stars 2 forks source link

[bug] Minor issue with table views #11

Closed T145 closed 1 year ago

T145 commented 1 year ago

Specifically in pfBlockerNG, the feed alias groups listed in tables can be completely unreadable. screenshot

beornlake commented 1 year ago

This is more of a pfBlockerNG problem rather than a theme issue. pfBNG has hard-coded in-line CSS that doesn’t use the theme variables, so the theme can’t override: Screenshot 2023-07-20-154758

callmekass commented 1 year ago

Closing because this is a problem with the pfBlockerNG package and not the theme.

pfBlocker could avoid having this issues with themes by:

  1. using classes instead of inline css
  2. adding a border color instead of a background color
  3. using a "status" column to portray information instead of styling
callmekass commented 1 year ago

The pfBlockerNG file causing the problem is HERE if anyone wants to checkout their repo and fix it.