search

callmekass / pfSense-palenight

[DEPRECATED] A palenight inspired theme for pfSense and pfSense+
Apache License 2.0
35 stars 2 forks source link

Navigation Tabs Border Color #7

Closed beornlake closed 1 year ago

beornlake commented 1 year ago

Not sure if this is a 'bug' or 'working as intended', but the border-bottom attribute of inactive navigation tabs might need to be changed from --foreground to --contrast at line 251.

In the official themes, inactive tabs don't have a visible bottom border, which improves contrast when determining which tab is 'active' at a glance. With the current settings, it feels like there may not be enough contrast here:

Screenshot 2023-04-07-151334

callmekass commented 1 year ago

Changing the background color on active tabs to --second-background. This should make the active tab more apparent.

callmekass commented 1 year ago

Fix is done. Waiting for merge to main.