search

callstack / react-native-builder-bob

👷‍♂️ Simple set of CLIs to scaffold and build React Native libraries for different targets
https://callstack.github.io/react-native-builder-bob/
2.78k stars 184 forks source link

fix: make sure react-native.config.json is shipped with each library Fixes #647 #648

Closed johnf closed 2 weeks ago

johnf commented 2 weeks ago

Summary

With the new introduction of https://github.com/callstack/react-native-builder-bob/commit/a90142f471d3c39bd5f9a98c17a64ff23be9b8af#diff-4282562f42ade49c2eb46dee36bcbb7987322efec211330f48387a10e5514678R206 that adds includeGeneratedCode, react-native.config.js needs to be shipped with the NPM module to signal what directory to use.

Test plan

Tested react-native-vector-icons where I discovered this issue against my project.

atlj commented 2 weeks ago

LGTM Thanks for sending this!

migueldaipre commented 5 days ago

Hey @johnf, @atlj.

Does the .json file exist? I think the correct one is .js, right? [Reference]

johnf commented 5 days ago

@migueldaipre You are right. Wasn't thinking straight after hours of debugging this. Should have copied and pasted it from my library!

Fixed in https://github.com/callstack/react-native-builder-bob/pull/659