callstack / react-native-image-editor

A library providing an API for cropping images from the web and the local file system.
MIT License
366 stars 117 forks source link

Update "react-native" peerDependencies to allow usage with latest RN versions #107

Closed MoOx closed 8 months ago

MoOx commented 2 years ago

Summary

If this is working with 0.64, there is no reason it shouldn't work with 0.65-0.68 afaik. This prevent "npm yelling" if you want to install it.

Test plan

npm install with recent npm version (> 8.5 probably) which breaks install if peer deps are not respected.

Fritsen commented 1 year ago

+1

However, for now, it can be fixed decently with the new npm "overrides"-feature


"overrides": {
    "@react-native-community/image-editor": {
      "react": "$react",
      "react-native": "$react-native"
    }
},`
retyui commented 8 months ago

thanks for PR, this issue was fixed in: https://github.com/callstack/react-native-image-editor/pull/125