callstack / react-native-image-editor

A library providing an API for cropping images from the web and the local file system.
MIT License
366 stars 117 forks source link

fix: incompatibility with AGP 8 & remove jcenter #122

Closed mateusz1913 closed 8 months ago

mateusz1913 commented 8 months ago

Summary

fix: incompatibility with AGP 8 & remove jcenter

Test plan

Create test 0.73 RN app, install the library and run the app

thymikee commented 8 months ago

Can we use backwards compatible version that @atlj and @satya164 shared? https://github.com/react-native-community/discussions-and-proposals/issues/671#issuecomment-1604910280

atlj commented 8 months ago

Can we use backwards compatible version that @atlj and @satya164 shared? react-native-community/discussions-and-proposals#671 (comment)

We've made some changes over that solution. The latest is here: https://github.com/callstack/react-native-builder-bob/blob/8e0e96b7fcf0159cde12067e35bf06e5dec81679/packages/create-react-native-library/templates/native-common/android/build.gradle#L52C2-L52C2

And here are the two related PRs:

  1. https://github.com/callstack/react-native-builder-bob/pull/399
  2. https://github.com/callstack/react-native-builder-bob/pull/431
satya164 commented 8 months ago

Here is a diff https://gist.github.com/satya164/e508e1be04650a68d76a993f5384ffd0

thymikee commented 8 months ago

Let’s merge it and fix CI separately. Likely unrelated