callstack / react-native-image-editor

A library providing an API for cropping images from the web and the local file system.
MIT License
376 stars 118 forks source link

BREAKING CHANGE: Use promise instead of callback #29

Closed guhungry closed 5 years ago

guhungry commented 5 years ago

Summary

Currently the api use callback pattern instead of easier to use Promise api.

Test Plan

What's required for testing (prerequisites)?

None

What are the steps to reproduce (after prerequisites)?

Test with example app for both Android and iOS

Compatibility

OS Implemented
iOS
Android

Checklist

Trancever commented 5 years ago

@guhungry Could you fix eslint errors (you can check it by running yarn test:eslint)? Module works fine with Promises so once there are no errors we can merge it! thanks!

guhungry commented 5 years ago

@Trancever Done with cherry pick and rebase to master.