callstack / react-native-image-editor

A library providing an API for cropping images from the web and the local file system.

MIT License

376 stars 118 forks source link

fix: Add missing ContentResolver scheme #30

Closed Sroka closed 5 years ago

Sroka commented 5 years ago

Summary

This library is using ContentProvider on Android as a mean to read image data and as such should accept all schemes handled by ContentProvider. Before this PR only URIs with file and content schemas were recognized as local URIs . This PR adds android.resource scheme what enables us to read apps resources.

Test Plan

Try to read any app asset such as "android.resource:///drawable/.png"

What's required for testing (prerequisites)?

Adding some android asset to the app and trying to crop it.

What are the steps to reproduce (after prerequisites)?

Try to read any app asset such as "android.resource:///drawable/.png" EX: User is able to read that asset AR: User is not able to read that asset
Compatibility

OS	Implemented
Android	✅

Checklist

[X ] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

Trancever commented 5 years ago

@Sroka Awesome, thanks for PR!