search

callstack / react-native-image-editor

A library providing an API for cropping images from the web and the local file system.
MIT License
376 stars 118 forks source link

Yellow box: "Warning: Calling bridge.imageLoader is deprecated and will not work in newer versions of RN. Please update to themoduleForClass API or turboModuleLookupDelegate API." #56

Closed dkoo closed 6 months ago

dkoo commented 4 years ago

Bug

This Yellow Box warning appears whenever using the cropImage method of this library. Maybe due to the use of _bridge.imageLoader here.

Simulator Screen Shot - iPhone 11 - 2020-01-30 at 12 53 06

Environment info

React Native info output:

System:
    OS: macOS Mojave 10.14.5
    CPU: (8) x64 Intel(R) Core(TM) i7-8569U CPU @ 2.80GHz
    Memory: 19.75 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 12.11.0 - ~/.nvm/versions/node/v12.11.0/bin/node
    npm: 6.11.3 - ~/.nvm/versions/node/v12.11.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.0, DriverKit 19.0, macOS 10.15, tvOS 13.0, watchOS 6.0
    Android SDK:
      API Levels: 28, 29
      Build Tools: 28.0.3, 29.0.2
      System Images: android-29 | Google APIs Intel x86 Atom
  IDEs:
    Android Studio: 3.5 AI-191.8026.42.35.5977832
    Xcode: 11.0/11A420a - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: 0.61.5 => 0.61.5
  npmGlobalPackages:
    react-native-rename: 2.4.1

Library version: ^2.2.0

Steps To Reproduce

  1. Call cropImage with debug mode enabled.
  2. The image is correctly cropped, but the Yellow Box warning appears when the response is returned.
MamyChow commented 4 years ago

Same issue

benzman81 commented 4 years ago

Same here.

sokoldjala commented 4 years ago

The solution is to replace _bridge.imageLoader with [_bridge moduleForName:@"ImageLoader" lazilyLoadIfNecessary:YES] in here, It should be fixed in the next release.

Trancever commented 4 years ago

@sokoldjala Would you like to submit a PR fixing this issue?

Psiiirus commented 4 years ago

@dkoo this ticket is completed, isn't it?

retyui commented 6 months ago

Right, it was fixed and released in 2.3.0