Default profile colors - Githubissues

callstack / react-native-material-palette

Bringing Material Palette API to React Native

MIT License

104 stars 11 forks source link

Default profile colors #27

Closed rgommezz closed 7 years ago

rgommezz commented 7 years ago

After sampling some images, I extrapolated some greyscale colors as defaults for each profile. See https://github.com/callstack-io/react-native-material-palette/issues/2

This PR merges the palette instance with the defaults, before the event emitter publish the change to all subscribers.

TODO

[x] Validate this.props.defaults
[x] Fix Flow
[x] Unit test createMaterialPalette
[x] Defaults should be only provided for the types passed
[x] Unit test defaults merging in PaletteProvider

Note: I'll fix flow issues before merging this...couldn't run it again locally

coveralls commented 7 years ago

Coverage increased (+0.7%) to 92.593% when pulling 6f5926840ff61f35b3604c1b9b842c74251a3060 on default_profile_colors into 8ad6872039022f99f6988267c3186211403ad8b4 on master.

coveralls commented 7 years ago

Coverage increased (+0.7%) to 92.531% when pulling 0f1c7c1d0bd718d696648c48e6076ceca4e578b3 on default_profile_colors into 8ad6872039022f99f6988267c3186211403ad8b4 on master.

coveralls commented 7 years ago

Coverage increased (+0.7%) to 92.531% when pulling c8de2409267ce24a11b5dab4ce6e707901474753 on default_profile_colors into 8ad6872039022f99f6988267c3186211403ad8b4 on master.

coveralls commented 7 years ago

Coverage increased (+0.7%) to 92.531% when pulling 3b70ee79c52e1be5c753dbed9436ea3c05a4a770 on default_profile_colors into 8ad6872039022f99f6988267c3186211403ad8b4 on master.

coveralls commented 7 years ago

Coverage increased (+5.6%) to 97.51% when pulling 41c95bd089f19c08ea877da17c3f74cba8043aed on default_profile_colors into 8ad6872039022f99f6988267c3186211403ad8b4 on master.

rgommezz commented 7 years ago

@satya164 @zamotany you can take another look 🤖

coveralls commented 7 years ago

Coverage increased (+5.6%) to 97.51% when pulling 95d5ae4d8a13cd6136d57a9c9a1ac2f677aa49be on default_profile_colors into 8ad6872039022f99f6988267c3186211403ad8b4 on master.

coveralls commented 7 years ago

Coverage increased (+5.6%) to 97.51% when pulling f564ad160bb6ceb6c9af479ae1c507cabb4b5d49 on default_profile_colors into 8ad6872039022f99f6988267c3186211403ad8b4 on master.

coveralls commented 7 years ago

Coverage increased (+5.6%) to 97.51% when pulling 8054f5bf6f30da80b2efbb6939e46a06dfef487c on default_profile_colors into 8ad6872039022f99f6988267c3186211403ad8b4 on master.

coveralls commented 7 years ago

Coverage increased (+6.9%) to 98.77% when pulling 6ba98c4227f4645c9d0226372fc45113ff1729ef on default_profile_colors into 8ad6872039022f99f6988267c3186211403ad8b4 on master.

coveralls commented 7 years ago

Coverage increased (+7.3%) to 99.18% when pulling 1578bf531ee3479af3d5d50e9b0ee03e480ea59d on default_profile_colors into 8ad6872039022f99f6988267c3186211403ad8b4 on master.

satya164 commented 7 years ago

You guys are crazy

coveralls commented 7 years ago

Coverage increased (+8.1%) to 100.0% when pulling 57e157604e0dca4fdc058f98f41353be81f419ef on default_profile_colors into 8ad6872039022f99f6988267c3186211403ad8b4 on master.

coveralls commented 7 years ago

Coverage increased (+8.1%) to 100.0% when pulling 993bfe10fbfca37bc644e0e8816bf47fffa1e6b6 on default_profile_colors into 8ad6872039022f99f6988267c3186211403ad8b4 on master.