Feat/app example - Githubissues

callstack / react-native-material-palette

Bringing Material Palette API to React Native

MIT License

104 stars 11 forks source link

Feat/app example #30

Closed rgommezz closed 7 years ago

rgommezz commented 7 years ago

Basic Example, nothing fancy.

[x] Create example with other APIs
[x] Update documentation
[x] Double check override in kotlin, make it work in all versions: This is not backwards compatible as per my tests. Kotlin yells with versions prior to 0.47 during the build with the below error:

createJSModules' hides member of supertype 'ReactPackage' and needs 'override' modifier

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 5ebcc9addc40077e6647a0a56d3eb51e225de947 on feat/app_example into 102e55bd28905f98e82012294229bbb9036d9912 on master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 662bdc0e14e839c41b1d6872e8a25fbdda1f2cfc on feat/app_example into 102e55bd28905f98e82012294229bbb9036d9912 on master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling f773fd794ddf76d45d97265537dbcfa884366d0f on feat/app_example into 102e55bd28905f98e82012294229bbb9036d9912 on master.

rgommezz commented 7 years ago

@satya164 I don't know how to solve the backwards compatibility with Kotlin, maybe you have some ideas. Apparently the solution works properly in Java. Maybe we can write that boilerplate file in Java and leave the one with the logic with Kotlin?

Also, if you wanna improve the example with different colors/images, feel free to take over this one or create a different one once it's merged. That way, I can in the meantime work on the medium article 🤖

satya164 commented 7 years ago

I've never really written kotlin, but I'll give it a try today.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 1832071a50de559e91773ae61d66f93c3dc76559 on feat/app_example into 102e55bd28905f98e82012294229bbb9036d9912 on master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 42f6535af3ce6391b59ec3ae57c99aa99ee7052c on feat/app_example into 74f57f743c71407626063a4aefe7313104f3a0bc on master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling da611276545b0b8b177e2b5f5716abab21953f84 on feat/app_example into 2baecd3acb695564f9ae96d7ea677dafcc0ec24a on master.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 078449fcb2de28fd9092caef23fdb6e1ac890d6b on feat/app_example into 2baecd3acb695564f9ae96d7ea677dafcc0ec24a on master.