search

callstack / react-native-opentok

React Native OpenTok
202 stars 79 forks source link

The code is not compatible with react 15.5+ #41

Closed clementdevosmc closed 7 years ago

clementdevosmc commented 7 years ago

Hello,

I've been trying (after ejecting expo and setup my project...) to implement this in my project but the code is using React.PropTypes that have been moved to the 'prop-types' package.

I think it won't be a big update to use these prop types instead of React's. I'll make a PR tomorrow because this is blocking if you want the code to run on React 15.5+

Do you see anything else blocking this library with react 15.5+?

Source https://reactjs.org/docs/typechecking-with-proptypes.html

Cheers, Clément

clementdevosmc commented 7 years ago

Created PR #43

michalchudziak commented 7 years ago

Hey!

Thanks for your feedback. We rewrote the library completely, which results in API changes and many bug fixes. If the issue still persists on the latest version, please re-open it.

Thanks!