search

callstack / react-native-opentok

React Native OpenTok
202 stars 79 forks source link

Android API version 26 and 27 #71

Closed krokhale closed 6 years ago

krokhale commented 6 years ago

I can confirm that this works on API version 23,24 and 25. And it's crashing on 26 and 27.

krokhale commented 6 years ago

According to your readme:

Supported OpenTok SDK version:

OpenTok SDK 2.11.+

I believe opentok just added support for Oreo(26 and 27) in 2.12+, is there an upgrade path for react-native-opentok to start using 2.12+

screen shot 2017-11-24 at 4 01 46 pm
dratwas commented 6 years ago

Thanks for your report. Here is PR with the upgrade. https://github.com/callstack/react-native-opentok/pull/67 It will be merged soon.

krokhale commented 6 years ago

Perfect thanks! Though i did manage to find a workaround for now. Will update whenever you folks merge.

dratwas commented 6 years ago

@krokhale It's merged. could you check if it works for you?

krokhale commented 6 years ago

Sorry just getting to this now, tested on API 26 and 27, the video call starts and it does not crash on dev. Though it crashes on call disconnect. Could be related to this issue, since we have only tested with Oreo 8 on dev:

https://github.com/callstack/react-native-opentok/issues/76

We have just pushed out a new version to production. Will post a comment here if it crashes after disconnect on production too.

Also to anyone reading this, in order to update your react-native-opentok use this:

yarn add https://github.com/callstack/react-native-opentok

instead of

yarn add react-native-opentok

Thanks for your work!