Disconnect crashing the app on all Android versions - Using Latest Opentok 2.12

callstack / react-native-opentok

React Native OpenTok

202 stars 79 forks source link

Disconnect crashing the app on all Android versions - Using Latest Opentok 2.12 #78

Open krokhale opened 6 years ago

krokhale commented 6 years ago

Just tested. The call disconnect is crashing on all android versions in the latest react-native-opentok 2.12

Both .disconnectAll and .disconnect are crashing.

renanpupin commented 6 years ago

Same problem here, I downgraded the SDK to 2.10 and everything works fine but it will be nice if we can fix that in the latest version.

krokhale commented 6 years ago

True, but 2.10 crashes on Oreo, so it's now a choice between the two.

wzywno commented 6 years ago

Hi @krokhale @renanpupin Did you resolve this issue or find any workaround?

TeruyaHaroldo commented 6 years ago

Hi @krokhale

With the 2.13. I was debugging here and found some tips but nothing that resolve the problem.

In RNOpenTokPublisherView.cleanUpPublisher, when I remove/comment 'mPublisher.destroy()' line, the application don't crash, BUT, the in the App.js freeze and eventually, I can't connect again.

Help!

TeruyaHaroldo commented 6 years ago

@krokhale just for curiosity, what's the consequences if I remove the 'mPublisher.destroy()'?

timhuff commented 6 years ago

From what I can tell, .destroy() tries to re-free a resource that was freed when the component is removed. But it appears that it also stops the camera. When I commented it out, the camera wouldn't close. My solution was to keep it commented out but then also call .disconnectAll.

timhuff commented 6 years ago

Pull request indicating the change. https://github.com/callstack/react-native-opentok/pull/88 The readme should probably be updated to indicate the necessity of .disconnectAll.