Screen Sharing PR causes problems building

callstack / react-native-opentok

React Native OpenTok

202 stars 79 forks source link

Screen Sharing PR causes problems building #97

Open kmiracle86 opened 6 years ago

kmiracle86 commented 6 years ago

/node_modules/react-native-opentok/ios/RNOpenTokScreenSharingCapturer.m:133:1: Control reaches end of non-void function

In this block of code

/**
 * Dispatch lambda function to stop the queue from invoking handler block.
 */
- (int32_t)stopCapture
{
    _capturing = NO;
    dispatch_sync(_queue, ^{
        if (_timer) {
            dispatch_source_cancel(_timer);
        }
    });
}

kmiracle86 commented 6 years ago

Fixed in #98

rptasznik commented 6 years ago

I am seeing this same error now after trying to install the react native opentok package with the instructions here, https://github.com/callstack/react-native-opentok#installation