callstack / react-native-pager-view

React Native wrapper for the Android ViewPager and iOS UIPageViewController.

MIT License

2.68k stars 412 forks source link

chore: migrate example to `react-native-test-app` #834

Closed szymonrybczak closed 1 month ago

szymonrybczak commented 3 months ago

Summary

In this Pull Request I've migrated Example project to react-native-test-app.

	Old arch	New arch (Bridgeless)
Android
iOS

Test Plan

App should properly run and build on all platforms that react-native-pager-view supports.

Compatibility

OS	Implemented
iOS	✅
Android	✅
visionOS	✅

Checklist

[x] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I updated the typed files (TS and Flow)

troZee commented 3 months ago

@szymonrybczak could you rebase your PR? 🙏

szymonrybczak commented 3 months ago

CI is failing for iOS E2E tests because app built inside Release mode cannot grab .jsbundle, I tried also in a fresh project and it looks like something is broken: CleanShot 2024-07-01 at 15 12 41@2x

npx --package react-native-test-app@latest init
yarn build:ios
yarn ios --mode "Release"

cc: @tido64 any ideas? Is there maybe anything that I'm missing in the config for app to run properly?

tido64 commented 3 months ago

cc: @tido64 any ideas? Is there maybe anything that I'm missing in the config for app to run properly?

When is pod install run? It needs to be run after bundling so that CocoaPods can create an entry for it in the generated Xcode project files. You can check if it's present if you open .xcworkspace in Xcode.

szymonrybczak commented 2 months ago

@tido64 I did give it a try, and it seems like the results is still the same :(

tido64 commented 2 months ago

@szymonrybczak Do you have repro steps? Seems to work for me. This is what I ran:

yarn
cd example
yarn
yarn build:ios
pod install --project-directory=ios
yarn ios --no-packager --simulator 'iPhone 15 Pro'