callstack / react-native-pager-view

React Native wrapper for the Android ViewPager and iOS UIPageViewController.
MIT License
2.68k stars 412 forks source link

cause pod install error (No package name found) #841

Open nightohl opened 3 months ago

nightohl commented 3 months ago

Environment

Description

image

I installed react-native-pager-view for using react-native-tab-view. but when I operate pod install on the commandline in ios folder of my project, an error accures with saying "error Failed to build the app: No package name found."

image

So I checked out the history of "AndroidManifest.xml" file, I could see two commits that edit this file.

the package name was changed from "com.reactnativecommunity.viewpaper" to "com.reactnativepagerview" and this seems defenately intended,

but the latest commit named "example" commit has removed the package name from the file. I guess this is a mistake as almost things are just changed in example folder, so I infered this is a petty issue, and it should be rolled back.

Reproducible Demo