callstack / react-native-pager-view

React Native wrapper for the Android ViewPager and iOS UIPageViewController.

MIT License

2.68k stars 412 forks source link

fix(ios): update content view frame based on new layout metrics #853

Closed QichenZhu closed 1 month ago

QichenZhu commented 1 month ago

Summary

Related issues: https://github.com/callstack/react-native-pager-view/issues/852, https://github.com/Expensify/App/issues/41810

Proposal: https://github.com/Expensify/App/issues/41810#issuecomment-2248527381

Test Plan

What's required for testing (prerequisites)?

Build the examples with the new architecture.

What are the steps to reproduce (after prerequisites)?

Run the iOS examples app.
Open the Basic Example.
Click the Control tab.

Expected result: the background should fill the available space.

Videos

Before the fix:

https://github.com/user-attachments/assets/d3eaa71d-ad94-4498-969b-589d2c8bcc5b

After the fix:

https://github.com/user-attachments/assets/a02964b4-90f0-4fa9-ae9b-84d7b6cbb90a

Compatibility

OS	Implemented
iOS	✅
Android	❌

Checklist

[ ] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I updated the typed files (TS and Flow)

troZee commented 1 month ago

https://github.com/callstack/react-native-pager-view/releases/tag/v6.3.4