search

callstack / react-native-paper

Material Design for React Native (Android & iOS)
https://reactnativepaper.com
MIT License
12.71k stars 2.07k forks source link

React-Native 0.61.x #1341

Closed marcorm closed 4 years ago

marcorm commented 4 years ago

Environment

Android API Level 26 RN 0.61.x react-native-paper stable and alpha

Description

I noticed a problem with react-native-paper and react-native 0.61.x on Android API Level 26. Doesn't happen on API Level 23 or 29.

When i open a Dialog inside a Portal it shows up weird. Same problem with FAB.

The problem doesn't arise with RN 0.60.5. It happens with the last versions of react-native-paper (stable and alpha).

Here are two attachments showing the issue: RN 0.60.5

RN 0.61.x

P.S. don't pay attention to Icons in the bottom tab.

Reproducible Demo

Just start a new project with RN 0.61.x and put a FAB or a Portal inside it with react-native 0.61.x on Android API Level 26.

EDIT: Repository to reproduce the issue

P.S. I don't know if its RN issue or a RNP issue. I also posted it here: https://github.com/react-native-community/releases/issues/140#issuecomment-533790202

alradadi commented 4 years ago

running into the same issue on Android

marcorm commented 4 years ago

I found out something: putting a normal Button (from react-native) inside the Dialog (instead of react-native-paper Button) fixes the issue. EDIT: i created this repo to reproduce the issue with minimal code: https://github.com/marcorm/rn061_rnp_issue/tree/master

marcorm commented 4 years ago

I know it's not a react-native-paper issue but, as stated here setting borderRadius to undefined solves the problem.

Ludus-Team commented 4 years ago

It's not just on dialog, it's happen on Android with elevation View (Upgrade to 0.61.0 and still the same problem)

With 0.60.5: Screenshot_1569395991

With 0.61.0: Screenshot_1569396036

usmansbk commented 4 years ago

Facing the same problem with Fab

gdoudeng commented 4 years ago

I am facing this problem and hope to solve it as soon as possible.

carlosroberto555 commented 4 years ago

+1 Same issue with FAB

satya164 commented 4 years ago

https://github.com/facebook/react-native/pull/26682

satya164 commented 4 years ago

Fixed in RN 0.61.2 https://github.com/facebook/react-native/releases/tag/v0.61.2

marcorm commented 4 years ago

Great

deadcoder0904 commented 4 years ago

Hey, @satya164 I am still getting this error. I'm on v0.61.2 👇

bug icon

I've also opened an issue on RN 👉https://github.com/facebook/react-native/issues/26740 which contains the repro steps

zcmgyu commented 4 years ago

Confirmed still get the error on React Native 0.61.5

todorone commented 4 years ago

@satya164 This issue is still around with latest RN versions, please reopen it...