callstack / react-native-paper

Material Design for React Native (Android & iOS)
https://reactnativepaper.com
MIT License
12.88k stars 2.09k forks source link

Decrease Checkbox animation duration #143

Closed ferrannp closed 4 years ago

ferrannp commented 7 years ago

Try to match it to native Android where it is faster.

satya164 commented 7 years ago

What should be the duration?

ferrannp commented 7 years ago

I don't have a number, we should compare it to native app. Or hey, we can use the native component (It is in RN repo).

satya164 commented 7 years ago

we can use the native component (It is in RN repo)

it's the stock OS one. it'll not be material themed on pre-lollipop.

gawrysiak commented 6 years ago

I have used AZ Screen Recorder for Android to look into it a bit deeper.

screen shot 2018-04-03 at 22 09 04First one is Android 6.0 - settings page. It takes ~0.4s to finish.

screen shot 2018-04-03 at 22 09 41Somewhere in the middle (0.2s) the checkbox transition is over.

screen shot 2018-04-03 at 22 09 59Then it's still another 0.2s to finish the ripple effect and background color transition.

screen shot 2018-04-03 at 22 11 24Second one is Paper inside the Expo app. It takes ~0.7s to finish.

screen shot 2018-04-03 at 22 11 37The empty checkbox appeared a bit faster, but it takes some more time before it reaches the full size. The background & ripple effect goes darker than native.

screen shot 2018-04-03 at 22 11 49Somewhere in the middle (0.35s) the checkbox transition is over.

screen shot 2018-04-03 at 22 12 04For Paper it takes more time before the background goes back to the original color & ripple is gone completely.

ferrannp commented 6 years ago

Thanks @gawrysiak ! We'll try to use it :)

github-actions[bot] commented 4 years ago

Hello 👋, this issue has been open for more than 2 months with no activity on it. If the issue is still present in the latest version, please leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution on workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix the issue.

Trancever commented 4 years ago

Checkbox animation duration should be configurable with a animation.scale property from theme. It should be implemented in a same way as in Menu

github-actions[bot] commented 4 years ago

Hello 👋, this issue has been open for more than 2 months with no activity on it. If the issue is still present in the latest version, please leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution on workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix the issue.

karthick-cs commented 2 years ago

When I click the checkbox it takes some delay to show the tick. how to stop the animation. my code is `<TouchableOpacity activeOpacity={0.6} onPress={()=> this.toggleSelected(item)}>

{item.name}
                                </TouchableOpacity>}`