Material Tab Navigator not compatible with iPhone 12

callstack / react-native-paper

Material Design for React Native (Android & iOS)

https://reactnativepaper.com

MIT License

12.77k stars 2.08k forks source link

Closed comvenger-brandon closed 3 years ago

comvenger-brandon commented 3 years ago

The dependency react-native-safe-area-view should be changed to "^2.0.0", which supports the iPhone 12 series.

At the moment, the safe area does not work properly on iPhone 12.

github-actions[bot] commented 3 years ago

Couldn't find version numbers for the following packages in the issue:

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

markterm commented 3 years ago

I can see this issue with:

react-native: 0.63.3 react-native-paper: 4.2.0 react-native-vector-icons: 7.0.0

hirbod commented 3 years ago

I can confirm this. The fix was to:

expo install react-native-safe-area-view@next react-native-safe-area-context@next

If you're not on expo, just make sure that you install them with yarn/npm and make sure to have v2 and not 1.1.1

And add this to your package.json (below devDependencies on root level)

  "resolutions": {
    "react-native-safe-area-view": "^2.0.0"
  },

LRNZ09 commented 3 years ago

I still have this issue with react-native-paper version 4.3.1

hirbod commented 3 years ago

@LRNZ09 just pick the workaround I've posted. Works flawlessly

LRNZ09 commented 3 years ago

@Hirbod your workaround works, but I'd like the @callstack team to take care of this bug

mars-lan commented 3 years ago

@Trancever any chance we can get this fixed soon?

HughBerryman commented 3 years ago