search

callstack / react-native-paper

Material Design for React Native (Android & iOS)
https://reactnativepaper.com
MIT License
12.88k stars 2.09k forks source link

Using components from `react-native-gesture-handler` to improve performance #2888

Closed k3-cat closed 3 years ago

k3-cat commented 3 years ago

Is your feature request related to a problem? Please describe.

Encountering performance issue when putting lots of components (such as TextInput) in a same screen.

Describe the solution you'd like

Import components (such as TextInput and Touchables) directly from react-native-gesture-handler instead of react-native. They have exactly the same API, so theoretically no extra adaptations need to do.

In addition, implement ripple effect and other animations with react-native-reanimated. This do required extra adaptations.

As most of the large react native projects (or projects that using react-navigation) rely on those to package, it should not be a problems that involving new dependences.

Describe alternatives you've considered

Environments

Additional context

https://docs.swmansion.com/react-native-gesture-handler/docs/api/components/touchables https://github.com/software-mansion/react-native-reanimated

github-actions[bot] commented 3 years ago

Couldn't find version numbers for the following packages in the issue:

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

github-actions[bot] commented 3 years ago

Hey! Thanks for opening the issue. The issue doesn't seem to contain a link to a repro (a snack.expo.io link or link to a GitHub repo under your username).

Can you provide a minimal repro which demonstrates the issue? A repro will help us debug the issue faster. Please try to keep the repro as small as possible and make sure that we can run it without additional setup.

KrifaYounes commented 3 years ago

i am alright with, if you want we can create a branch with this features together

github-actions[bot] commented 3 years ago

Hello 👋, this issue has been open for more than a month without a repro or any activity. If the issue is still present in the latest version, please provide a repro or leave a comment within 7 days to keep it open, otherwise it will be closed automatically. If you found a solution or workaround for the issue, please comment here for others to find. If this issue is critical for you, please consider sending a pull request to fix it.