search

callstack / react-native-paper

Material Design for React Native (Android & iOS)
https://reactnativepaper.com
MIT License
12.98k stars 2.1k forks source link

[newarch][android] portal now flickers when onDismiss #4555

Open lovegaoshi opened 4 days ago

lovegaoshi commented 4 days ago

Current behaviour

Hi! I've noticed the portal element now may flicker when its exited via onDismiss, under the new arch. its fine when exited via onClose. its fine with the old arch.

Expected behaviour

portaled component does not flicker

How to reproduce?

https://snack.expo.dev/@react-native-paper/more-examples---comprehensive-portal-example with expo 52

Preview

N/A

What have you tried so far?

I have deduced its visibleRef.current is still true when at the end of onDismiss, so its shown again. so I removed it and it seems to work normally now

Your Environment

software version
ios N/A
android 14
react-native 0.76.2
react-native-paper 5.12.5
node 20
npm or yarn 4
expo sdk 52
arasrezaei commented 3 days ago

same here, there is flicker for menu, dialog components on dismiss