callstack / react-native-slider

React Native component exposing Slider from iOS and SeekBar from Android
MIT License
1.21k stars 270 forks source link

Remove space before and after the slider bar #98

Open canyavall opened 5 years ago

canyavall commented 5 years ago

When a new Slideer is created, it is created inside a view and I can see an space before and after the slider (just set backgroundColor='red' on the style)

This is quite annoying in order to make it if with other components as the slider is always a bit smaller

Is this done in purpose? Can those spaces (padding or margin) be removed and make the bar use 100%

I tried setting the padding, margin, left, right to 0, but nothing...

ogabrielsantos commented 5 years ago

You could temporarily put it inside a view with negative margins:

<View style={{ marginLeft: -10, marginRight: -10 }}>
  <Slider />
</View>
brunoziie commented 4 years ago

This behavior affects both platforms?

moriyuu commented 4 years ago

Is this issue still alive? I'd like to work on this issue but the example app doesn't reproduce this.

charitha95 commented 3 years ago

Or with marginHorizontal: -10

lucidlive commented 3 years ago

I see this issue only on Android. I applied the following style to the slider:

marginLeft: Platform.select({ ios: 0, android: -15 }),
marginRight: Platform.select({ ios: 0, android: -15 })

Kinda annoying but it works.

lirkang commented 2 years ago

I see this issue only on Android. I applied the following style to the slider:

marginLeft: Platform.select({ ios: 0, android: -15 }),
marginRight: Platform.select({ ios: 0, android: -15 })

Kinda annoying but it works.

it works, thanks

Chr1k0 commented 1 year ago

The issue seems to be still there. The "margin trick" works on android for me but it causes that one tick extra is added to the upper/right limit - with no change in value. so not very useful. :(

matt-dalton commented 1 year ago

Anyone got an idea of how to select the margin values - are you just doing it by eye? It looks better with -3 for iOS on our app, but unsure if this is due to different screen sizes/resolutions etc. Is setting a constant value for each platform robust?

AlexanderHott commented 3 months ago

Any update on this, I still see this on version 4.5.2