search

callstack / react-native-testing-library

🦉 Simple and complete React Native testing utilities that encourage good testing practices.
https://callstack.github.io/react-native-testing-library/
MIT License
3.07k stars 271 forks source link

chore: fix extend-expect.d.ts types by internalizing them #1536

Closed mdjastrzebski closed 10 months ago

mdjastrzebski commented 10 months ago

Summary

Fixes #1534

It moves are dependant types definitions for things like Style, AccessibilityValueMatcher, etc to inside the file, are referencing other TS did not seem to work.

This is more of a workaround, as we now have mentioned types declared twice, so it would be to refactor it later to work it more automatically.

Test plan

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (01c770d) 98.18% compared to head (cad9790) 98.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1536 +/- ## ======================================= Coverage 98.18% 98.18% ======================================= Files 99 99 Lines 5888 5888 Branches 913 913 ======================================= Hits 5781 5781 Misses 107 107 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mdjastrzebski commented 10 months ago

This PR has been replaced by #1537.