callstack / react-native-testing-library

🦉 Simple and complete React Native testing utilities that encourage good testing practices.
https://callstack.github.io/react-native-testing-library/
MIT License
3.07k stars 271 forks source link

chore: tweak docs and examples to match recommended practices 2024 (use screen object for queries) #1561

Closed vanGalilea closed 6 months ago

vanGalilea commented 8 months ago

Summary

Changes to lib.'s docs and example code to align with @mdjastrzebski's blog "Recommended practices for React Native Testing Library in 2024"

This part touches the following

Test plan

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.50%. Comparing base (a282d1e) to head (1c64b86). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1561 +/- ## ========================================== - Coverage 95.51% 95.50% -0.02% ========================================== Files 99 99 Lines 5400 5400 Branches 857 857 ========================================== - Hits 5158 5157 -1 - Misses 242 243 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vanGalilea commented 8 months ago

@mdjastrzebski hi hi 👋🏻 this one is ready for review

vanGalilea commented 8 months ago

codecov we have a (-0.02%) code coverage decrease, though I haven't removed/changes any test cases 🤷🏻‍♂️ 😓

vanGalilea commented 7 months ago

@mdjastrzebski can you please have a look at this PR?

mdjastrzebski commented 7 months ago

@vanGalilea thanks for your patience. I'll try to look this or next week.

mdjastrzebski commented 6 months ago

@vanGalilea Thanks for submitting this PR!