search

callstack / react-native-visionos

A framework for building native visionOS applications using React
https://callstack.github.io/react-native-visionos-docs/
MIT License
847 stars 28 forks source link

Update tsconfig to not crash tsserver with visionos files #100

Closed bartlomein closed 5 months ago

bartlomein commented 5 months ago

Summary:

TSserver is crashing while opening the repo as discussed in this issue

Changelog:

Test Plan:

Open the repo with vscode, tsserver should no longer crash

okwasniewski commented 5 months ago

@bartlomein Thanks for the PR! Unfortunately, it's not that simple - we can't change this package as we are reusing it from the core repo (https://www.npmjs.com/package/@react-native/typescript-config).

Edit: I misread the file you changed (you just replaced it's content). I would prefer to keep reusing the upstream implementation of this

But if you are willing to contribute to the core React native repo, I think adding something like this: 

"exclude": [
    "**/Pods/**"
  ]

Should do the trick for every OOT platform that's building Hermes from the source. Theoretically, you can also build Hermes from a specified commit when using a stable version of React Native so I think it's valid.

bartlomein commented 5 months ago

Ahh ok makes sense. Sounds good, will set it up there! Thanks!