search

callstack / react-native-visionos

A framework for building native visionOS applications using React
https://callstack.github.io/react-native-visionos-docs/
MIT License
1.02k stars 30 forks source link

Building for archive to upload to app store fails #127

Closed bartlomein closed 7 months ago

bartlomein commented 8 months ago

Description

Product -> Archive produces several bugs and the build fails. One is in hermes-engine and another one says it is being built forvisionOS-simulator even though "Any VisionOS Device" is selected in the top build menu

Steps to reproduce

Open Xcode and follow steps to build for App store deployment. Build app.

React Native Version

0.73.4-1

Affected Platforms

Other (please specify)

Output of npx react-native info

none

Stacktrace or Logs

none

Reproducer

none

Screenshots and Videos

Screenshot 2024-03-07 at 11 32 10 AM Screenshot 2024-03-07 at 11 31 13 AM

bartlomein commented 8 months ago

I commented out the use of vsnprintf inside of Logging.cpp and it worked. However I'm guessing thats not a long term solution

okwasniewski commented 8 months ago

I think at the current state of the project (building Hermes from source) you might need to clean the build folder before archiving so inside of visionOS folder:

  1. rm -rf Pods build
  2. Install pods again
  3. Build the app for release

I'm waiting for CMake 3.28.4 to be released with important fixes which will unblock us for moving forward with shipping a precompiled version of Hermes engine

okwasniewski commented 7 months ago

Looks like this is a duplicate of #128 as the same issues are described by other people there - let's keep one of them open.