search

callstack / react-native-visionos

A framework for building native visionOS applications using React
https://callstack.github.io/react-native-visionos-docs/
MIT License
1.02k stars 30 forks source link

Hover style API: variable border radius #69

Closed okwasniewski closed 9 months ago

okwasniewski commented 10 months ago

Description

The goal of this issue is to adapt hoverStyle API to properly use variable corner radius for each corner of the view. This is a continuation of the work done in #66

okwasniewski commented 10 months ago

@gokul1099 Created an issue for the feature you was working on

gokul1099 commented 10 months ago

@okwasniewski looks like PR #66 is broken and not working now. Can you check once.

gokul1099 commented 10 months ago

@okwasniewski while working for PR #66 I made all the changes in RCTViewComponentView file and it works. But after recent commits any changes in RCTViewComponentView is not reflecting. I even added breakpoint and it's not working. Any recent changes are causing this ? Any idea on this ??

okwasniewski commented 10 months ago

@gokul1099 Can you try installing pods with RCT_NEW_ARCH_ENABLED=1 flag? Recently in core they changed that RNTester is not building with new arch by default

gokul1099 commented 10 months ago

@gokul1099 Can you try installing pods with RCT_NEW_ARCH_ENABLED=1 flag? Recently in core they changed that RNTester is not building with new arch by default

oh ok, let me try

gokul1099 commented 10 months ago

@gokul1099 Can you try installing pods with RCT_NEW_ARCH_ENABLED=1 flag? Recently in core they changed that RNTester is not building with new arch by default

I tried this still not working

okwasniewski commented 9 months ago

@gokul1099 Another change I missed upstream is that we are now running Bridgeless mode by default. This PR fixes hoverStyle for bridgeless mode: #92, so you should be now able to see your breakpoints

gokul1099 commented 9 months ago

@okwasniewski I don't think this is specific to hoverStyle prop. Currently none of the methods in the RCTViewComponentView is being invoked.

okwasniewski commented 9 months ago

This feature has been tackled by @saadnajmi in this PR: https://github.com/facebook/react-native/pull/43078 - which will be soon cherry-picked to react-native-visionos

okwasniewski commented 9 months ago

fixed by: #114