callstack / react-native-visionos

A framework for building native visionOS applications using React
https://callstack.github.io/react-native-visionos-docs/
MIT License
977 stars 28 forks source link

Empty repo after init script #93

Closed panzacoder closed 7 months ago

panzacoder commented 8 months ago

Description

Excited to get started playing with visionOS!

I ran npx @callstack/react-native-visionos@latest init YourApp, the output I got is below in "Stacktrace or logs"

A folder YourApp was created, but it only contains a .git directory, no other files or folders.

Steps to reproduce

run npx @callstack/react-native-visionos@latest init YourApp

React Native Version

0.73.3

Affected Platforms

Other (please specify)

Output of npx react-native info

no output because the react-native project is not being initialized.

Stacktrace or Logs

npx @callstack/react-native-visionos@latest init YourApp

               ######                ######
             ###     ####        ####     ###
            ##          ###    ###          ##
            ##             ####             ##
            ##             ####             ##
            ##           ##    ##           ##
            ##         ###      ###         ##
             ##  ########################  ##
          ######    ###            ###    ######
      ###     ##    ##              ##    ##     ###
   ###         ## ###      ####      ### ##         ###
  ##           ####      ########      ####           ##
 ##             ###     ##########     ###             ##
  ##           ####      ########      ####           ##
   ###         ## ###      ####      ### ##         ###
      ###     ##    ##              ##    ##     ###
          ######    ###            ###    ######
             ##  ########################  ##
            ##         ###      ###         ##
            ##           ##    ##           ##
            ##             ####             ##
            ##             ####             ##
            ##          ###    ###          ##
             ###     ####        ####     ###
               ######                ######

                  Welcome to React Native!
                 Learn once, write anywhere

⠼ Downloading templateerror Installing pods failed. This doesn't affect project initialization and you can safely proceed.
However, you will need to install pods manually when running iOS, follow additional steps in "Run instructions for iOS" section.

✖ Downloading template

info 💡 To enable automatic CocoaPods installation when building for iOS you can create react-native.config.js with automaticPodsInstallation field.
For more details, see https://github.com/react-native-community/cli/blob/main/docs/projects.md#projectiosautomaticpodsinstallation

  Run instructions for Android:
    • Have an Android emulator running (quickest way to get started), or a device connected.
    • cd "/Users/jshebert/Development/plfx/YourApp" && npx react-native run-android

  Run instructions for iOS:
    • cd "/Users/jshebert/Development/plfx/YourApp/ios"

    • Install Cocoapods
      • bundle install # you need to run this only once in your project.
      • bundle exec pod install
      • cd ..

    • npx react-native run-ios
    - or -
    • Open YourApp/ios/YourApp.xcodeproj in Xcode or run "xed -b ios"
    • Hit the Run button

  Run instructions for macOS:
    • See https://aka.ms/ReactNativeGuideMacOS for the latest up-to-date instructions.

Reproducer

https://github.com/panzacoder/bad-rn-visionOS/tree/main

Screenshots and Videos

Above repo is only provided to meet the repro requirement, there is nothing to share because the script fails.

Sorry if this is a basic issue, I normally use Expo and so am not sure what I'm missing here if anything.

okwasniewski commented 8 months ago

Hey!

Can you try it out one more time? I've just tried it on my second mac and everything works flawlessly. You can also try skipping Pods installation during init.

Screenshot 2024-02-05 at 18 47 07
panzacoder commented 8 months ago

Same results. I have yarn 4.0.1 installed globally, not sure if that matters, but from my experience yarn versions can be managed in the repo itself, unless there is a script dependency on it?

panzacoder commented 8 months ago

I just tried npx @callstack/react-native-visionos@latest init YourApp --npm and that seemed to work (I got to the prompt to install cocoapods, which hadn't happened before).

It's installing now so I think the issue is with yarn.

okwasniewski commented 8 months ago

Great, can you try out initializing a normal project with nightly version (it uses the latest CLI)? npx react-native@nightly init TestProject and if the issue persists, open a new one here: https://github.com/react-native-community/cli

We are reusing community-cli for the init script, and it looks like there might be an issue in the CLI itself.

panzacoder commented 8 months ago

Ok, I was able to get it installed, but since it created a package-lock.json I got errors when getting to the yarn visionos step:

 yarn visionos
Internal Error: SpatialNotes@workspace:.: This package doesn't seem to be present in your lockfile; run "yarn install" to update the lockfile
    at $x.getCandidates (/Users/jshebert/.yarn/releases/yarn-4.0.1.cjs:205:8149)
    at Bd.getCandidates (/Users/jshebert/.yarn/releases/yarn-4.0.1.cjs:141:1311)
    at /Users/jshebert/.yarn/releases/yarn-4.0.1.cjs:210:8334
    at Yy (/Users/jshebert/.yarn/releases/yarn-4.0.1.cjs:140:53922)
    at xe (/Users/jshebert/.yarn/releases/yarn-4.0.1.cjs:210:8314)
    at async Promise.allSettled (index 0)
    at async Uc (/Users/jshebert/.yarn/releases/yarn-4.0.1.cjs:140:53250)
    at async /Users/jshebert/.yarn/releases/yarn-4.0.1.cjs:210:9065
    at async Qi.startProgressPromise (/Users/jshebert/.yarn/releases/yarn-4.0.1.cjs:140:137290)
    at async St.resolveEverything (/Users/jshebert/.yarn/releases/yarn-4.0.1.cjs:210:7063)

If I remove the package.lock & node_modules and run yarn to install fresh, I just get an error about the nightly being unavailable:

 yarn
➤ YN0000: · Yarn 4.0.1
➤ YN0000: ┌ Resolution step
➤ YN0082: │ @react-native/codegen@npm:0.74.0-nightly-20240131-82e9a5e4f: No candidates found
➤ YN0000: └ Completed in 2s 173ms
➤ YN0000: · Failed with errors in 2s 181ms

I'll try out the standard init as well

panzacoder commented 8 months ago

Confirmed, same error there. I'll open another ticket.

Not sure what my workaround would be for now, so I guess I'll just put a pin in this.

okwasniewski commented 8 months ago

Interesting, the version of codegen you have issues with is released on npm, so Im not sure why it has issues with it:

Screenshot 2024-02-05 at 19 56 41
okwasniewski commented 8 months ago

Can you try to initialize the project with yarn classic?

yarn set version classic

I curious if this will work

giovanijfc commented 8 months ago

Can you try to initialize the project with yarn classic?

yarn set version classic

I curious if this will work

This work for me! Thanks!!!

okwasniewski commented 8 months ago

@panzacoder Can you post the CLI issue here once you create it?

okwasniewski commented 7 months ago

Hey @panzacoder is this still reproducible? I can't reproduce this on yarn v4

panzacoder commented 7 months ago

@okwasniewski Sorry, I haven't been able to spend more time on this. You can close this and I will come back and reopen if I reproduce in the future.

okwasniewski commented 7 months ago

Sounds good, if you will encounter this in the future please open an issue in CLI repo. Thanks

szymonrybczak commented 7 months ago

hey @panzacoder, make sure to test it out with --verbose and also when you have higher Yarn version globally installed, please make sure that in your root directory you don't have package.json because that create strange issues.