search

callstack / react-theme-provider

A set of utilities that help you create your own React theming system in few easy steps
MIT License
466 stars 54 forks source link

Support for peerDependency of react@^17.0.0 #125

Open zizzle6717 opened 2 years ago

zizzle6717 commented 2 years ago

Describe the feature

Expand peerDependency to also include react above v17

Motivation

Dependency tree error in latest versions of node/npm

Dashue commented 2 years ago

Encountering this as well, any update?

AntonyF-Andreani commented 1 year ago

I found this problem too, a possible fix to improve support also to React 18 must be:

https://github.com/callstack/react-theme-provider/blob/master/package.json#L54

Change to:

{
    "peerDependencies": {
        "react": "^16.3.0 || ^17.0.2 || ^18.0.0",
    }
}

also this with combination of issue https://github.com/callstack/react-theme-provider/issues/144