search

callstack / reassure

Performance testing companion for React and React Native
https://callstack.github.io/reassure/
MIT License
1.26k stars 28 forks source link

[Improvement] replace the unmaintained markdown-builder package #451

Closed meteorlxy closed 7 months ago

meteorlxy commented 8 months ago

Describe the improvement

The markdown-builder package is no longer maintained since 2019.

It introduces a redundant legacy version of husky in its dependencies, which pollutes the dependency tree:

https://github.com/callstack/reassure/blob/04825689671482beca6f90010436c44c878076e3/yarn.lock#L6318-L6323

Although it could be resolved by the "resolutions" feature of some package manager, I think it could be better to replace it totally from the @callstack/reassure-compare package.

I found there is a fork mr_markdown_builder and maybe we can make use of it directly?

thymikee commented 7 months ago

Hey, would you like to contribute this in a pull request maybe? :)

mdjastrzebski commented 7 months ago

I've did a quick check where do we use markdown builder and it's pretty minimal. We just use headers.h1, headers.h3 emphasis.b and emphasis.i. Replacements for this should be easy to add to reassure-compare directly. @meteorlxy would you like to contribute it?