search

callstackincubator / bs-react-navigation

A fast, declarative navigation for React Native, based on React Navigation
MIT License
55 stars 5 forks source link

Tab navigator #9

Closed czystyl closed 5 years ago

czystyl commented 5 years ago

related to #1

grabbou commented 5 years ago

Now that this PR is open, I am cross-posting comment from another PR so that it doesn't get lost: https://github.com/callstackincubator/bs-react-navigation/pull/8#pullrequestreview-186080367

czystyl commented 5 years ago

@vnovick Do you use the refmt? I see that some part of the codebase is not formatted.

I started checking, and what I faced at the beginning is that we lose the standard animations. It could be caused by the fact that we render only one component but want to check it. I'll go deep into implementation later on.

BTW. The tab navigator is working, and it's great! 🎉🎉🎉

ezgif com-resize 1

vnovick commented 5 years ago

@czystyl, Yeah. I use refmt. It's just It wasn't enabled because of formatOnSave setting in Vscode was false. I needed that for different project and forgot to turn on. We actually don't render one component. We pass screens config to createBottomTabNavigator so not sure why there are no animations