Update to bs-platform v4 + Remove Warning

[broerjuang]

Hi guys,

Just let me know if I need to improve this PR.

• [x] Update to recent release of bucklescript

• [x] Remove warning because of unused variable declaration *

• [x] Change The implementation of crossFadeInterpolation function from accepting list of float to named arguments.

• I try to remove these warnings.

  

but not this

** For this case, I think it might be better to open module locally to reduce the shadowing warning. And I think it can also improve readability (it's very subjective ;) ) . What do you think?

[knowbody]

yeah, I agree. We shouldn't be having these warnings.

[broerjuang]

@knowbody absolutely will do!

[broerjuang]

Btw, will do this the rest tonight (it's 13 PM in my country :) )

[knowbody]

Sure, no rush. Thank you

On Mon, 23 Jul 2018 at 07:59, Juang Wiantoro notifications@github.com wrote:

Btw, will do this the rest tonight (it's 13 PM in my country :) )

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/callstackincubator/rebolt-navigation/pull/120#issuecomment-406947907, or mute the thread https://github.com/notifications/unsubscribe-auth/ADoDp52SCmdAc6RKB4NuCXakKxa5ayRJks5uJWZXgaJpZM4VaYSJ .

[broerjuang]

There's one warning left, which is coming from node_modules @knowbody

[knowbody]

@broerjuang thank you so much for this PR! great work