search

callstats-io / webrtc-demoapp

Another journey towards understanding WebRTC. In the end it should resemble demo.callstats.io, probably with more features?
MIT License
5 stars 2 forks source link

Ch899/room name #15

Closed lennart-csio closed 7 years ago

lennart-csio commented 7 years ago

https://app.clubhouse.io/callstatsio/story/899/set-roomname-when-call-starts

@karthikbr82

lennart-csio commented 7 years ago

i rebased this o Ch892/waitCSIOinit, but it doesnt show?

lennart-csio commented 7 years ago

callstats is initialized each time the room name changes. is this ok?

karthikbr82 commented 7 years ago

will the popup appear if the URL contains the roomID already?

lennart-csio commented 7 years ago

yes, it adds the roomID to the popup, so just a click on OK is necessary. this makes more sense, when the popup asks for more information, e.g. a username (to be displayed in chat, under the video, etc).

karthikbr82 commented 7 years ago

LGTM