Open Steveb-p opened 6 years ago
Hi again @Steveb-p! You're absolutely welcome to update README and explain how to configure context in react-sip
. Strategically-wise, I guess it's worth supporting the new context API since it's so elegant. I have not seen any libraries that support both APIs yet, but if you come across one, feel free to share!
If we don't find means to use both APIs simultaneously, we can just move to a new UI in one of the future 0.x
releases. Not sure what the best timing is, but I guess that as long as we provide easy-to-follow migration instructions, it won't be a disaster.
@kachkaev as far as new context API goes, new one would force React version to 0.16+, which is probably not what you want, so I'd postpone this until at least redux, redux-router or redux-form switch to it.
This is very much an issue now. In React 17, the old context API has been deprecated and this library's context no longer works.
@alexgurr I'll see if I can do anything about it in the evening.
Is there any solution or prevision to that problem of context API?
Any update on this or chance to move the project forward?
I’m afraid I don’t have any capacity to maintain this package. If anyone would like to work on it, please ping me or @denisnikulin! 🙏
Ok, thanks will have a word internally and see if I can get someone to help out
@MattRiddell Personally I have been using https://github.com/OpenTelecom/react-sip-phone, but it seems that it might need an extra maintainer too.
Hey @areski long time! Cool I'll check out both and discuss it in our morning dev stand up tomorrow. I was using WebRTC with a custom signaling protocol but SIP may be easiest going forward. Thanks for the pointer!
Hi @MattRiddell, I have the same context problem on a project i'm working on. Could you kindly give me pointers as to how to use webRTC with custom signaling to connect to SIP server
Just wanted to note that there is a new (16.3) React context API that changes how contexts work. I'd like to improve readme by adding information about how to use the old context in applications (since I completely forgot :) ) and since I'm looking to use the library for longer I'd like to get your opinion on adding capability to work with new Provider/Consumer based context API. Preferably while maintaining legacy API somewhere I guess?