search

callum-oakley / json5-rs

A Rust JSON5 serializer and deserializer which speaks Serde.
ISC License
184 stars 23 forks source link

Generate errors when unable to parse int or float instead of panic #8

Closed vdonich closed 5 years ago

vdonich commented 5 years ago

it would be nice if we kept the underlying error

Agreed, but this is still an improvement, so the library doesn't panic on errors, so I would do that separately. Also, I was trying to keep new errors in the same format as the existing ones, so that might at least give ability for lib users to have a chance to work around this.

@callum-oakley let me know what you think about this one - I think rest of the comments are addressed.

callum-oakley commented 5 years ago

Nice, thanks again!