search

callum-ramage / ctrl-dir-scroll

Add ctrl-up/down single line scrolling to Atom
MIT License
7 stars 4 forks source link

"Big" scroll and new key bindings #21

Closed kankaristo closed 9 years ago

kankaristo commented 9 years ago

The current Linux key bindings don't work in most desktop environments (Unity, Gnome, etc.), because they are used for switching workspaces. These are now the same as on Windows (Ctrl-up and Ctrl-down).

I would also like to change the default OS X key bindings (so that they would be the same across platforms), but these have to be confirmed not to conflict with anything else. I can check this next week, unless someone else reports on this sooner.

This pull request also has a new "big" scroll feature, which is bound to Ctrl-Shift-up/down (Ctrl-Alt-Shift-up/down on OS X). It scrolls 10 lines at a time, which is extremely useful for long files. The amount of lines to scroll can be changed in the package's settings. Now this package and line-jumper are a perfect match. :)

Also in this pull request is the ability to configure whether you want to keep the cursor on the screen. Personally, I don't, because I essentially want this package to behave like mouse scrolling (without the mouse).

Sorry for putting 3 different things into one pull request, I can split this up if you don't want to merge something.

kankaristo commented 9 years ago

This should fix https://github.com/callum-ramage/ctrl-dir-scroll/issues/12.

clickbait commented 9 years ago

The default OSX bindings were made to match Sublime's bindings for the same feature.

callum-ramage commented 9 years ago

The changes look good. The intent was to match the key bindings of other editors on the platform of choice so I would rather leave it as ctrl-alt-up/down on OS X. I'll probably get around to merging this tomorrow.

kankaristo commented 9 years ago

Ah, alright. I'll leave the key bindings as they are then. :)