search

callumacrae / vue-test

:checkered_flag: DEPRECATED: Component testing for Vue.js
90 stars 6 forks source link

For discussion: Mount API that takes a single object #7

Open asselin opened 7 years ago

asselin commented 7 years ago

EXAMPLE to be discussed-- mount API that takes 1 options object instead of 3 parameters

callumacrae commented 7 years ago

This is a good idea. I guess that because the second argument is already an object it wouldn't be possible to just detect whether someone is using arguments or an object :(

asselin commented 7 years ago

@callumacrae Do you have any issue with me merging in this PR--- it will break the existing API, but in the end I think it's for the best

asselin commented 7 years ago

Also, have you seen this discussion re: unit testing in Vue: https://forum.vuejs.org/t/is-anything-being-done-in-core-vue-to-make-unit-testing-easier/7431/9 ? Are you interested in participating?

callumacrae commented 7 years ago

Yep, I like the API changes made in this PR. Looks like it needs a bit of cleaning up and documenting, but happy for you to merge :)

Hadn't seen that, will sign up and reply.