search

callumbwhyte / meganav

A flexible, draggable link picker for constructing site navigation menus in Umbraco
MIT License
35 stars 34 forks source link

v12 support? #72

Closed ruant closed 4 months ago

ruant commented 10 months ago

Looks like v12 added some new methods that needs to be implemented in https://github.com/callumbwhyte/meganav/blob/v9/dev/src/Our.Umbraco.Meganav/PublishedContent/PublishedElementProperty.cs ??

A member was added to an interface without a default implementation.
Umbraco.Cms.Core.Events.IEventAggregator.Publish2(System.Collections.Generic.IEnumerable{0})
Umbraco.Cms.Core.Events.IEventAggregator.PublishAsync2(System.Collections.Generic.IEnumerable{0},System.Threading.CancellationToken)
Umbraco.Cms.Core.Models.PublishedContent.IPublishedProperty.GetDeliveryApiValue(System.Boolean,System.String,System.String)
Umbraco.Cms.Core.Models.PublishedContent.IPublishedPropertyType.ConvertInterToDeliveryApiObject(Umbraco.Cms.Core.Models.PublishedContent.IPublishedElement,Umbraco.Cms.Core.PropertyEditors.PropertyCacheLevel,System.Object,System.Boolean,System.Boolean)
Umbraco.Cms.Core.Models.PublishedContent.IPublishedPropertyType.ConvertInterToDeliveryApiObject(Umbraco.Cms.Core.Models.PublishedContent.IPublishedElement,Umbraco.Cms.Core.PropertyEditors.PropertyCacheLevel,System.Object,System.Boolean)
Umbraco.Cms.Core.Models.PublishedContent.IPublishedPropertyType.DeliveryApiCacheLevel
Umbraco.Cms.Core.Scoping.ICoreScope.Locks
Umbraco.Cms.Core.Migrations.IMigrationPlanExecutor.ExecutePlan(Umbraco.Cms.Infrastructure.Migrations.MigrationPlan,System.String)
Umbraco.Cms.Infrastructure.Search.IUmbracoIndexingHandler.RemoveProtectedContent
Umbraco.Cms.Infrastructure.Examine.IUmbracoIndex.SupportProtectedContent
afabri73 commented 5 months ago

Today I upgrade Umbraco 11.5.0 to 12.3.6 and I encourred the same error.

Any update about v12 compatibility? Because if it no updates, I must think to uninstall it and use another package.

Can you help us? Thanks

afabri73 commented 5 months ago

Hi callumbwhite, you pushed a pull request (#74) to resolve this issue. Try it and I hope this fix the problem.

Bye Adriano

callumbwhyte commented 4 months ago

Hello everybody,

Thanks for your continued use & support for Meganav.

A fix including support for Umbraco v12 and v13 has been merged – you will find v4.1.0 of Meganav is now available on NuGet.

Callum

afabri73 commented 2 months ago

Hi Callum, unfortunately I have problems also with version 4.1.0 (umbraco v12.3.9)

Here you can find the screenshot of the error: https://github.com/callumbwhyte/meganav/issues/73#issuecomment-2049368735