callumlocke / json-formatter

Makes JSON easy to read.
https://chrome.google.com/webstore/detail/json-formatter/bcjindcccaagfpapjjmafapmmgkkhgoa?hl=en
BSD 3-Clause "New" or "Revised" License
3.76k stars 859 forks source link

build system not working as expected(?) - missing options.js file in output #258

Open alexanderankin opened 11 months ago

alexanderankin commented 11 months ago

Hi Callum, thanks for a great plugin - I tried building from source and found that the options.js file wasn't being generated anymore.

other things i found were that in order not to perturb the pnpm lockfile, you have to run npx pnpm@7 --frozen-lockfile i - perhaps someone with more pnpm experience than me would be able to be confident in a lockfile upgrade to the latest lockfile version. unfortunately, I wasn't able to figure out how to run the deno task commands using the lockfile in the repo (deno insisted on upgrading from lockfile version 2 to 3) - but this would have been one of the things i was trying to check.

the main issue I am seeing is that the options.html clearly suggests the presence of the options.js file, presumably being compiled from options.ts - but it is not being generated.

steps to reproduce:

git clone $url
cd json-formatter
npx pnpm@7 --frozen-lockfile i
deno task build
find dist/options

expected output:

dist/options
dist/options/options.html
dist/options/options.js

actual output:

dist/options
dist/options/options.html

I'm not sure if im missing something or this is an actual bug.