search

callumrollo / erddaplogs

Quick utilities for parsing nginx and apache logs for ERDDAP requests
MIT License
0 stars 4 forks source link

Make it work on jupyterhub #11

Closed callumrollo closed 1 month ago

callumrollo commented 1 month ago

Probably needs some path magic

ERROR: file:///home/user/notebooks/erddaplogs does not appear to be a Python project: neither 'setup.py' nor 'pyproject.toml' found.

mwengren commented 1 month ago

My approach was to attempt to install the package in my JupyterHub environment via pip local path reference, which sometimes works if the required package metadata files (as listed in error message above) are present:

!pip install -e .

Hopefully, this shouldn't be a difficult fix. Thanks!

mwengren commented 1 month ago

By adding a single cell at the top of the notebook with a local pip install:

!pip install -e .

I'm now able to run the notebook in an ordinary JupyterHub, presumably with the addition of the pyproject.toml file!

Does this belong in the notebook or is it more something one should know to add only if necessary? In other words, since I can't create my own conda environment based off of the environment.yml file in this JupyterHub, this is a workaround I know to do.

callumrollo commented 1 month ago

Glad to hear it's working! We should definitely add some installation notes to the README so that people know how to get this running. I wouldn't include a pip install in the notebook itself, it's considered bad practice as people may run the notebook blind

callumrollo commented 1 month ago

Resolved!